fix(types): prevent implicit 32-bit overflow panic and OOM DoS in checkUint64#453
Merged
Conversation
Contributor
hobeone
commented
May 22, 2026
- Enforce math.MaxInt bounds check in checkUint64 to prevent negative-size slice allocations and implicit integer conversions panicking on 32-bit architectures.
- Enforce math.MaxUint32 bounds check in checkUint64 to prevent slice allocation length out of range panics on 64-bit architectures.
- On 64-bit platforms, allocating a slice of e.g. 4,000,000,000 elements will immediately trigger an Out-Of-Memory (OOM) crash, leading to a Denial of Service.
- Implement incremental slice allocation via min(count, 1024) and append in readBool, readSizes, readFolder, and readUnpackInfo to mitigate memory exhaustion DoS from maliciously large metadata counts. Any slice growth would only happen if the archive had more than 1024 files.
…ckUint64 - Enforce math.MaxInt bounds check in checkUint64 to prevent negative-size slice allocations and implicit integer conversions panicking on 32-bit architectures. - Enforce math.MaxUint32 bounds check in checkUint64 to prevent slice allocation length out of range panics on 64-bit architectures. - Implement incremental slice allocation via min(count, 1024) and append in readBool, readSizes, readFolder, and readUnpackInfo to mitigate memory exhaustion DoS from maliciously large metadata counts. - Dynamic slice growth via append has negligible performance impact as 7z decompression CPU cycles completely dominate total execution time (99.9%+).
Owner
|
Yeah, the bounds check was a, (what I thought was sufficient), crude guardrail to just stop The other changes look good to me, I think the default sizes are reasonable. |
bodgit
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.