fix(lzma2): prevent undefined bit shift overflow in dictionary calculation#456
Merged
Conversation
|
coverage: 75.131% (+0.2%) from 74.939% — hobeone:fix/lzma2-shift into bodgit:main |
hobeone
force-pushed
the
fix/lzma2-shift
branch
2 times, most recently
from
47b3aff to
d50c41c
Compare
…ation - Validate that the LZMA2 dictionary property byte p[0] is <= 40 (maximum valid dictionary size of 4GB) in NewReader before calculating DictCap. - Prevents an undefined bit shift overflow during runtime calculation when p[0] > 40. - Source: https://en.wikipedia.org/wiki/LZMA#LZMA2_format
bodgit
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was flagged by an LLM review - but it seems to make sense given the format described in the link below.