Made setting environment variable in test script compatible with multiple environments #566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
multiple environments Previously it only worked probably on linux only-systems. It had command `NODE_ENV='test'` which did not work under Windows. I had used library cross-env in order to make it runnable under windows
Owner
|
@shoter Sorry for late. Looks good. Thanks for your great work :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed solution
Use cross_env library to handle setting environment variable for test script.
Previously it only worked probably on linux only-systems. It had
command
NODE_ENV='test'which did not work under Windows.Tradeoffs
There will be new dependency for the package which has no vulnerabilities.
Testing Done
I run
yarn run teston Debian and on Windows 10 and it passed all 33 tests.