Skip to content

Fix #707: passing nodeRef prop causes dragging to become jittery #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 27, 2020
Merged

Fix #707: passing nodeRef prop causes dragging to become jittery #718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4ac577
Pass resizable ref as nodeRef (#707)
chrisstiles Jul 27, 2020
510107c
Remove nodeRef (#707)
chrisstiles Jul 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,26 +498,6 @@ class YourComponent extends Component {

If set to `true`, will allow dragging on non left-button clicks.

#### `nodeRef?: React.Ref<typeof React.Component>`

please see, https://github.com/STRML/react-draggable
```
If running in React Strict mode, ReactDOM.findDOMNode() is deprecated.
Unfortunately, in order for <Draggable> to work properly, we need raw access
to the underlying DOM node. If you want to avoid the warning, pass a `nodeRef`
as in this example:

function MyComponent() {
const nodeRef = React.useRef(null);
return (
<Rnd nodeRef={nodeRef}>
<div ref={nodeRef}>Example Target</div>
</Rnd>
);
}

```

## Test

``` sh
Expand Down
2 changes: 1 addition & 1 deletion src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -626,7 +626,7 @@ export class Rnd extends React.PureComponent<Props, State> {
cancel={cancel}
scale={scale}
allowAnyClick={allowAnyClick}
nodeRef={nodeRef}
nodeRef={{ current: this.getSelfElement() }}
>
<Resizable
{...resizableProps}
Expand Down