Optimize light configuration and caching#681
Open
bolshakov wants to merge 5 commits into
Open
Conversation
88923f9 to
ccf1403
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improved
System#lightcaching performance using pre-computed configuration digests and added better error messages with source locations.LightConfigurationDslinitialization#hashfor traffic/recovery control strategies -- allows comparing configurations effectivelyUndefined.instancelookup overhead) - there is more room for improvement here, but it does not play well with RBS.LightConfigurationDsl: Optimized for light caching with pre-computed digestSystemConfigurationDsl: For system-level configurationLegacyConfigurationDsl: For backward compatibility, used outside of system, will be removed eventually.Performance impact
More effective lights cashing enabled a massive performance gain on light lookup.
When we switch to "system lights", a hottest path will have a very little overhead for light instantiation: