Closed
Conversation
19 tasks
bobvandevijver
requested changes
Mar 14, 2025
Member
bobvandevijver
left a comment
bobvandevijver
left a comment
There was a problem hiding this comment.
Breaking change, needs a note in the upgrade docs.
macintoshplus
changed the title
bobvandevijver
requested changes
Jul 20, 2025
Member
bobvandevijver
left a comment
bobvandevijver
left a comment
There was a problem hiding this comment.
Still need to check the new classes but I'm out of time for today, but here are already some comments that need to adressed anyways
Member
There was a problem hiding this comment.
Changes to the services.yaml will need to have a yaml migration defined as well.
Co-authored-by: Bob van de Vijver <bobvandevijver@users.noreply.github.com>
Member
|
Closing in favour of #3617 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #3551