Taxonomy singular slug fix part 2 #2051
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andysh-uk Nice! Don't mind the failing tests.. I'll need to clean up the mess caused by Composer 2, PHPStan and ECS breaking at pretty much the same time. :-) |
|
Thanks @bobdenotter, I was a bit alarmed at the amount of failures following such a tiny change, but I know you'd rebased and I did see a lot activity in master around Composer! I'm happy with this now it's backwards compatible so I'll delete my own branch and update my own repo. |
|
Merging into 4.1 as well as master! |
bobdenotter
approved these changes
Oct 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from #2044, this prevents an exception being thrown when the
TaxonomyFillListenerhas not been added toservices.yml. Any existing links will still generate as '/categories/something', for example, until the new listener is added.@bobdenotter please review this before the next 4.1 release or it will break existing sites if
services.ymlis not updated.