Conversation
jamiebuilds
reviewed
Jan 29, 2018
| return projectIsValid; | ||
| return { | ||
| invalidMessages, | ||
| projectIsValid |
Member
There was a problem hiding this comment.
Don't you need to update install now as well?
Member
Author
There was a problem hiding this comment.
yes,, I am planning to call validate command from install to keep single flow for project validation.
Member
There was a problem hiding this comment.
I wouldn't call the command, I would call the util. Calling the command means the validate command is limited by whatever the install command wants to output
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to