[#114.1] Add iwyu enforcement to glfw_adapters and demo_app#121
Merged
thomasnemer merged 1 commit intomainfrom Nov 11, 2025
Merged
Conversation
## Changes - Add CXX_INCLUDE_WHAT_YOU_USE property to glfw_adapters library - Add CXX_INCLUDE_WHAT_YOU_USE property to prong_demo_app executable - Fix include violations in demo_app/main.cpp (add <string>, remove unused <cmath>) - Remove unused private scrollbar fields from Viewport component ## Impact - Enforces include-what-you-use for demo infrastructure - Prevents future include violations with --error flag - All builds and tests pass successfully Part of #114 - Make include-what-you-use mandatory for all example builds
This was referenced Nov 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements issue #117, part of #114 (Make include-what-you-use mandatory for all example builds).
This PR adds
CXX_INCLUDE_WHAT_YOU_USEenforcement to:glfw_adapterslibraryprong_demo_appexecutableChanges
CMakeLists.txt Updates
glfw_adapterslibrary targetprong_demo_appexecutable target--errorflag to fail builds on include violationsInclude Fixes
#include <string>, removed unused#include <cmath>-Wunused-private-fieldwarningsVerification
All checks pass:
mise build- No iwyu errorsmise build-examples- Demo app builds successfullymise test- All 17 tests passImpact
Related Issues