fix(@clack/prompts): handle carriage return output in taskLog#509
fix(@clack/prompts): handle carriage return output in taskLog#509colinaaa wants to merge 2 commits intobombshell-dev:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 64f726a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
|
while this may be a nice fix to have, its not the way we should fix this. the spinner has similar issues in that it is a "raw" prompt (doesn't inherit going forward, the spinner is going to be refactored to use the same rendering logic as every other prompt. The task log prompt should do the same, and that will solve this problem at the same time. an issue goes a long way here as not all this direction is written down in one place, so you couldn't really have known that refactor was in progress. |
|
@43081j thanks for your review! I'll create an issue instead. |
Summary
taskLograw message updates that use carriage returns so spinner frames do not accumulateerror()rendering behavior@clack/promptspatch releaseTest Plan
cd packages/prompts && pnpm test