Skip to content

feat: standard schema for validation#543

Open
florian-lefebvre wants to merge 6 commits into
bombshell-dev:mainfrom
florian-lefebvre:feat/standard-schema
Open

feat: standard schema for validation#543
florian-lefebvre wants to merge 6 commits into
bombshell-dev:mainfrom
florian-lefebvre:feat/standard-schema

Conversation

@florian-lefebvre
Copy link
Copy Markdown

@florian-lefebvre florian-lefebvre commented May 19, 2026

What does this PR do?

Allows using Standard Schema compatible libraries for validate(). Discussed on Discord.

Docs PR: bombshell-dev/docs#42

Type of change

  • Bug fix
  • Feature
  • Refactor (no behavior change)
  • Documentation
  • Performance improvement
  • Tests
  • Chore (dependencies, CI, tooling)

Checklist

  • pnpm test passes (or targeted tests for my change)
  • pnpm format has been run
  • I have added/updated tests for my changes (if applicable)
  • I have added a changeset

AI-generated code disclosure

  • This PR includes AI-generated code

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 19, 2026

🦋 Changeset detected

Latest commit: fd18aae

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@clack/prompts Minor
@clack/core Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 19, 2026

commit: fd18aae

Copy link
Copy Markdown
Contributor

@ghostdevv ghostdevv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the jsdoc comments above the validate options would need updating, as well as the docs https://github.com/bombshell-dev/docs/

Comment thread examples/basic/standard-schema-validation.ts Outdated
Comment thread packages/core/src/utils/validation.ts
Copy link
Copy Markdown
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great, changeset is perfect, just minor feedback on the example!

Comment thread examples/basic/standard-schema-validation.ts Outdated
Comment thread packages/core/src/utils/validation.ts
@florian-lefebvre
Copy link
Copy Markdown
Author

florian-lefebvre commented May 20, 2026

I also want to note that the PR does not support schema transforms (they will run but not be used). That would require more changes to represent input and output in types. Out of scope of this PR but if you're interested let me know!

@florian-lefebvre
Copy link
Copy Markdown
Author

@ghostdevv docs PR is available at bombshell-dev/docs#42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants