Accept signed int32 colors in validator#7
Merged
Merged
Conversation
The rgba() function returns signed int32 when alpha >= 128 (bit 31 set). The validator's u32 type rejected these negative values. Add a color type that accepts the full signed-to-unsigned 32-bit range.
commit: |
The rgba() function returns signed int32 when alpha >= 128 (bit 31 set). The validator's u32 type rejected these negative values. Add a color type that accepts the full signed-to-unsigned 32-bit range.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The
rgba()helper returns a signed int32 when alpha >= 128 (bit 31 is set via(a & 0xFF) << 24). JavaScript interprets this as a negative number. The validator'su32type (minimum: 0) rejects these values, causingvalidated()to throw on any color with full alpha — which is the default.Approach
Add a
colortype that accepts the full range from-0x80000000to0xFFFFFFFFand use it forbg,border.color, and textcolorfields. The underlying bit pattern is identical; the validator just needs to accept both signed and unsigned interpretations.Test plan
validated()accepts ops withrgba(40, 42, 54)(negative int32) without throwing