Use ast.Inspect instead of checkExpr and manually calls
#226
+15
−153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only have `checkExpr` to recursively find `ast.FuncList` to check its block. We do this both recursively but also for each known node that has an expression. Since we only care about the `FuncLit` it's better to just use `ast.Inspect` and check block for both `FuncDecl` and `FuncLit` already in `Run`. This removes a lot of code and might also be faster potentially. We might get diagnostics out of order but we never guaranteed a specific order.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only have
checkExprto recursively findast.FuncListto check its block. We do this both recursively but also for each known node that has an expression.Since we only care about the
FuncLitit's better to just useast.Inspectand check block for bothFuncDeclandFuncLitalready inRun.This removes a lot of code and might also be faster potentially. We might get diagnostics out of order but we never guaranteed a specific order.
Closes #223