Open
Conversation
Add explicit check for cuddling of expressions (with intersecting variables). This check is enabled by default but by switching it off it's allowed to cuddle expr everywhere assign, decl and inc/dec is allowed today.
|
coverage: 94.381% (+0.2%) from 94.206% — expr-cuddle into main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add explicit check for cuddling of expressions (with intersecting variables). This check is enabled by default but by switching it off it's allowed to cuddle expr everywhere assign, decl and inc/dec is allowed today.
NOTE⚠️
This is just a tracking PR for #244 since the change was minimal. This does not mean I plan to merge this any time soon. It can also be used to add some more examples on expected and unexpected results by having this check.
The test file now contains a few different variants that uses this checks but most other checks are turned off. E.g. the last test
mixingExprwould not pass with the default setup since other checks would require splitting the expressions and assignments.