You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This passes -c core.editor=true to git, setting the editor to the Unix true command (which exits immediately with code 0) for this single invocation only. When git rebase --continue needs to open an editor to confirm a commit message, it runs true instead — effectively auto-accepting the existing message without blocking.
Assessment: Correct and appropriate. The -c flag is the right mechanism here because it scopes the config override to a single invocation without modifying the user's git config.
Observations:
Windows compatibility — true is a POSIX command. On Windows, this works in practice because Git for Windows ships true in Git Bash, but it's a subtle assumption. No action needed unless Windows is an explicitly supported target.
No tests for RebaseContinue — There's no test coverage for this function (confirmed by searching *_test.go). This is understandable since testing interactive git rebase flows is difficult. Not a blocker.
Consistency with other rebase helpers — RebaseHere (git.go:381) and RebaseOntoHere (git.go:388) still use plain runInteractive("rebase", ...) without the editor override. If those ever encounter a commit message prompt, they'd block too. That said, initial rebase operations are less likely to hit this than --continue, so the targeted fix makes sense.
No issues blocking merge. The fix is minimal, safe, and solves a real UX problem in the gh stack continue flow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #49