feat: better support pull_request_target in "antora checker" action#129
Merged
benjaminParisel merged 6 commits intomainfrom Apr 16, 2024
Merged
Conversation
7 tasks
benjaminParisel
deleted the
feat/pr-antora-checker_better_support_pr-target
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that the commit of the PR branch is used when the action is triggered by
pull_request_targetand not the commit of the base branch.Improve debug logs and remove duplication.
Notes
This should fix what is described in bonitasoft/bonita-labs-doc#153 (comment).
This PR has been tested with bonitasoft/bonita-labs-doc#155
Covers bonitasoft/bonita-documentation-site#685