feat(antora-content-checker): improve attribute checking#133
Merged
benjaminParisel merged 5 commits intomainfrom Jun 19, 2024
Merged
feat(antora-content-checker): improve attribute checking#133benjaminParisel merged 5 commits intomainfrom
benjaminParisel merged 5 commits intomainfrom
Conversation
* generate a report error when attribute is missing/empty or when the value didn't meet the length requirement * Adding jsDoc for classes and method
Collaborator
Author
|
With this update, we generate this report when contribution check failed:
|
tbouffard
approved these changes
Jun 19, 2024
Member
tbouffard
left a comment
tbouffard
left a comment
There was a problem hiding this comment.
LGTM, nice work!
Tested with bonitasoft/bonita-doc#2731
tbouffard
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Result in action in this pull request
bonitasoft/bonita-doc#2731