Skip to content

refactor: use getShadowDomWarnings helper in suggest.ts#112

Closed
himerus wants to merge 1 commit intomainfrom
feature/escalation-prwarningfeedback-feature
Closed

refactor: use getShadowDomWarnings helper in suggest.ts#112
himerus wants to merge 1 commit intomainfrom
feature/escalation-prwarningfeedback-feature

Conversation

@himerus
Copy link
Copy Markdown
Contributor

@himerus himerus commented Mar 21, 2026

Summary

  • Replaces inline Shadow DOM warnings array in buildStyling() with the shared getShadowDomWarnings() helper from mcp-helpers.ts
  • Eliminates duplicated warning text that was flagged in PR Enhance suggest_usage to include styling guidance section #101 CodeRabbit review (🧹 Nitpick)
  • Messaging is now consistent across suggest_usage, narrative, and quick-ref handlers

Test plan

  • Build passes (pnpm run build — exit 0)
  • Only suggest.ts modified (1 file, 2 insertions, 4 deletions)
  • CI passes

🤖 Generated with Claude Code

Replace inline Shadow DOM warnings array in buildStyling() with the
shared getShadowDomWarnings() helper from mcp-helpers.ts, eliminating
duplicated warning text and keeping messaging consistent across
suggest_usage, narrative, and quick-ref handlers.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@himerus himerus enabled auto-merge March 21, 2026 04:18
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 21, 2026

Warning

Rate limit exceeded

@himerus has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 20 minutes and 12 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 74423294-4806-483d-93cb-60b1f87d8faa

📥 Commits

Reviewing files that changed from the base of the PR and between 470a7c3 and 7b7410e.

📒 Files selected for processing (1)
  • packages/core/src/handlers/suggest.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/escalation-prwarningfeedback-feature

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@himerus
Copy link
Copy Markdown
Contributor Author

himerus commented Mar 21, 2026

Closing — suggest.ts was heavily modified during the overnight anti-hallucination sprint (PRs #181, #183, #185, #187). The getShadowDomWarnings helper is already used in quick-ref.ts and the warnings in suggest.ts have been replaced with the validation nudge pattern. This change is now superseded by the sprint work.

@himerus himerus closed this Mar 21, 2026
auto-merge was automatically disabled March 21, 2026 11:54

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant