fix: harden release pipeline for reliable unattended npm publish#41
Merged
fix: harden release pipeline for reliable unattended npm publish#41
Conversation
|
Caution Review failedPull request was closed or merged during review Note
|
| Cohort / File(s) | Summary |
|---|---|
CI/CD Workflow .github/workflows/release.yml |
Added explicit Build step before Release; removed NPM_CONFIG_PROVENANCE: 'true' from Release environment variables. |
Build Configuration package.json |
Simplified prepublishOnly script to run only pnpm run build, removing the pnpm test step. |
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~3 minutes
Possibly related PRs
- fix(ci): chain release after CI + credential fix for semantic-release #30: Both PRs modify
.github/workflows/release.ymlto add/run a build step before the release job. - feat(ci): semantic-release automated publishing pipeline #22: Both PRs modify the same
.github/workflows/release.ymlworkflow file, adjusting release steps and environment configuration.
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Description check | The description provides context and root cause analysis but lacks required template sections including Type of change, Related issue, Tests added, and Checklist items. | Complete the description using the repository template: add Type of change checkbox, Related issue number, Tests added confirmation, and verification checklist items. |
✅ Passed checks (2 passed)
| Check name | Status | Explanation |
|---|---|---|
| Title check | ✅ Passed | The title accurately and specifically describes the main objective of hardening the release pipeline for reliable npm publishing, which aligns with the primary changes made. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Post copyable unit tests in a comment
- Commit unit tests in branch
feature/fix-harden-release-pipeline-for
📝 Coding Plan
- Generate coding plan for human review comments
Comment @coderabbitai help to get the list of available commands and usage tips.
This was referenced Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The release pipeline has failed on every run since v0.1.0 was published. Three fixes are required across two files.
Root Causes
1. OIDC provenance causes 404 on every publish
NPM_CONFIG_PROVENANCE: 'true'was added in PR #31. npm OIDC provenance for unscoped packages requires the package maintainer to link the GitHub repo in npmjs.com → Package Settings → Provenance. That setup was never done. Result: every release fails with: