fix: resolve changeset workspace resolution and npmrc auth#50
Merged
Conversation
|
Note
|
| Cohort / File(s) | Summary |
|---|---|
NPM Configuration /.npmrc |
Deleted the registry authentication line that used NPM_TOKEN; other .npmrc settings (e.g., engine-strict) unchanged. |
Package manifest package.json |
Removed "workspaces": ["packages/*"], dropping Yarn/PNPM workspace declaration from the manifest. |
PNPM workspace config pnpm-workspace.yaml |
Removed the packages: globs (e.g., . and packages/*), eliminating pnpm workspace package listing. |
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~20 minutes
Possibly related PRs
- Migrate release pipeline to changesets (PUBLISHING.md standard) #44: Changesets-based publishing and workspace layout adjustments that interact with removal of workspace configs and registry auth token.
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Description check | ❓ Inconclusive | The description includes problem statement, root cause analysis, specific fixes, and test plan, but omits several required template sections like Type of change, Related issue, Tests added checkbox, and Checklist items. | Complete the description by including all template sections: mark Type of change, add Related issue number, check Tests added status, and verify all Checklist items (type-check, lint, format, test, build, CHANGELOG entry). |
✅ Passed checks (2 passed)
| Check name | Status | Explanation |
|---|---|---|
| Title check | ✅ Passed | The title clearly summarizes the main changes: fixing changeset workspace resolution by adjusting pnpm-workspace.yaml and npmrc authentication configuration. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Post copyable unit tests in a comment
- Commit unit tests in branch
fix/changeset-workspace-resolution
📝 Coding Plan
- Generate coding plan for human review comments
Comment @coderabbitai help to get the list of available commands and usage tips.
…ge as workspace member Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This was referenced Mar 12, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
NPM publish has been failing on every push to main with:
```
🦋 error: Found changeset fix-pnpm-workspace-root for package helixir which is not in the workspace
```
Root Cause
@manypkg/get-packages(used by changesets) does NOT auto-include the root package for pnpm workspaces — only packages matchingpackages:globs inpnpm-workspace.yamlare returned. With onlypackages/*listed, the roothelixirpackage is invisible to changesets, so both pending changesets fail to resolve.Fixes
pnpm-workspace.yaml: Add.topackages:so changesets discovers the roothelixirpackage.npmrc: Remove the${NPM_TOKEN}auth line — CI setsNODE_AUTH_TOKEN(viaactions/setup-node), notNPM_TOKENas a standalone env var. Leaving the unfilled line causes pnpm warnings and potential auth failure during publish.Test Plan
changeset versionsucceeds →changeset publishauthenticates and publisheshelixirto npmSummary by CodeRabbit