Skip to content

fix: helix.d.ts HxSkeletonAttributes and HxSpinnerAttributes property drift#80

Merged
himerus merged 3 commits intodevfrom
feature/fix-helixdts-hxskeletonattributes-and
Mar 18, 2026
Merged

fix: helix.d.ts HxSkeletonAttributes and HxSpinnerAttributes property drift#80
himerus merged 3 commits intodevfrom
feature/fix-helixdts-hxskeletonattributes-and

Conversation

@himerus
Copy link
Copy Markdown
Contributor

@himerus himerus commented Mar 18, 2026

Summary

Consumer report from trip-planner project. HIGH.

Problem: Multiple component type definitions have drifted from actual CEM:

  1. HxSkeletonAttributes (helix.d.ts lines 318-324):

    • Types define: shape?, effect?
    • Actual CEM: variant, width, height, animated, loaded
  2. HxSpinnerAttributes (helix.d.ts line 906):

    • Types allow HxVariant (success, warning, etc.)
    • Actual CEM only accepts: default, primary, inverted
  3. 20+ event handlers declared in types but not in CEM, and vice versa:
    ...


Recovered automatically by Automaker post-agent hook

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 18, 2026

Warning

Rate limit exceeded

@himerus has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 17 minutes and 1 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 779701f5-b3e0-4ea2-9d23-98c13a5e9f7a

📥 Commits

Reviewing files that changed from the base of the PR and between a5beebe and 729fc6b.

📒 Files selected for processing (6)
  • .changeset/fix-skeleton-spinner-type-drift.md
  • .changeset/skeleton-spinner-drift.md
  • packages/core/src/handlers/generate-types.ts
  • packages/core/src/handlers/index.ts
  • src/cli/index.ts
  • tests/handlers/generate-types.test.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/fix-helixdts-hxskeletonattributes-and
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@himerus himerus merged commit 8f16a58 into dev Mar 18, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant