Conversation
WalkthroughModifies the GitHub Actions changeset workflow to conditionally skip changeset verification when the PR base branch is staging or main, supporting promotion PR workflows without requiring changeset files. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/changeset.yml (1)
3-5: 🧹 Nitpick | 🔵 TrivialConsider narrowing the workflow trigger scope.
The workflow triggers on PRs to
[main, dev, staging], but theifcondition now ensures the job only runs for PRs targetingdev. You could simplify by changing line 5 to:branches: [dev]This would prevent the workflow from even starting (and appearing as "skipped") on promotion PRs, providing a cleaner CI status view. However, keeping the broader trigger may be intentional if you plan to add different jobs for promotion PRs in the future.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/changeset.yml around lines 3 - 5, The workflow currently triggers on pull_request for branches: [main, dev, staging] but the job-level if only runs for PRs targeting dev; update the on: pull_request -> branches setting to only include dev (replace [main, dev, staging] with [dev]) so the workflow won't start for non-dev promotion PRs; modify the branches key under the on: pull_request block in .github/workflows/changeset.yml to implement this change.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In @.github/workflows/changeset.yml:
- Around line 3-5: The workflow currently triggers on pull_request for branches:
[main, dev, staging] but the job-level if only runs for PRs targeting dev;
update the on: pull_request -> branches setting to only include dev (replace
[main, dev, staging] with [dev]) so the workflow won't start for non-dev
promotion PRs; modify the branches key under the on: pull_request block in
.github/workflows/changeset.yml to implement this change.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: d3f6bb78-ab07-41d9-b9f3-06cbfb61c7ec
📒 Files selected for processing (1)
.github/workflows/changeset.yml
Summary
Problem
The 'Changeset Required' GitHub Actions check runs on ALL PRs, including promotion PRs (dev→staging, staging→main). Promotion PRs don't need changesets — the individual feature PRs already contain them. This caused a ghost pending check that blocked auto-merge on PR #89 and PR #90 for 4+ hours overnight.
Fix
Update the changeset CI workflow (likely
.github/workflows/changeset-check.ymlor similar) to skip when:staging(dev→staging promotion)Recovered automatically by Automaker post-agent hook
Summary by CodeRabbit