Skip to content

fix: exempt promotion PRs from 'Changeset Required' CI check#92

Merged
himerus merged 1 commit intodevfrom
feature/fix-exempt-promotion-prs-from-changeset
Mar 18, 2026
Merged

fix: exempt promotion PRs from 'Changeset Required' CI check#92
himerus merged 1 commit intodevfrom
feature/fix-exempt-promotion-prs-from-changeset

Conversation

@himerus
Copy link
Copy Markdown
Contributor

@himerus himerus commented Mar 18, 2026

Summary

Problem

The 'Changeset Required' GitHub Actions check runs on ALL PRs, including promotion PRs (dev→staging, staging→main). Promotion PRs don't need changesets — the individual feature PRs already contain them. This caused a ghost pending check that blocked auto-merge on PR #89 and PR #90 for 4+ hours overnight.

Fix

Update the changeset CI workflow (likely .github/workflows/changeset-check.yml or similar) to skip when:

  • The PR base branch is staging (dev→staging promotion)
  • The PR...

Recovered automatically by Automaker post-agent hook

Summary by CodeRabbit

  • Chores
    • Updated internal development workflow to streamline changeset verification for pull requests targeting main release branches.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 18, 2026

Walkthrough

Modifies the GitHub Actions changeset workflow to conditionally skip changeset verification when the PR base branch is staging or main, supporting promotion PR workflows without requiring changeset files.

Changes

Cohort / File(s) Summary
Changeset Workflow Guard
.github/workflows/changeset.yml
Adds conditional logic to skip changeset verification steps when the PR targets staging or main branches, enabling changesetless promotions while preserving standard validation for feature branches.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested labels

skip-changeset

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is incomplete, missing required sections like Type of change, Related issue number, Tests added confirmation, and Checklist items. The description is partially recovered and cut off mid-sentence. Complete the PR description by filling in all required template sections: select the appropriate Type of change (Bug fix), provide the related issue number (#89 or #90), confirm tests status, and check off applicable checklist items.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically summarizes the main change: exempting promotion PRs from the Changeset Required CI check, which is the primary intent of this changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/fix-exempt-promotion-prs-from-changeset
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
.github/workflows/changeset.yml (1)

3-5: 🧹 Nitpick | 🔵 Trivial

Consider narrowing the workflow trigger scope.

The workflow triggers on PRs to [main, dev, staging], but the if condition now ensures the job only runs for PRs targeting dev. You could simplify by changing line 5 to:

branches: [dev]

This would prevent the workflow from even starting (and appearing as "skipped") on promotion PRs, providing a cleaner CI status view. However, keeping the broader trigger may be intentional if you plan to add different jobs for promotion PRs in the future.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/changeset.yml around lines 3 - 5, The workflow currently
triggers on pull_request for branches: [main, dev, staging] but the job-level if
only runs for PRs targeting dev; update the on: pull_request -> branches setting
to only include dev (replace [main, dev, staging] with [dev]) so the workflow
won't start for non-dev promotion PRs; modify the branches key under the on:
pull_request block in .github/workflows/changeset.yml to implement this change.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In @.github/workflows/changeset.yml:
- Around line 3-5: The workflow currently triggers on pull_request for branches:
[main, dev, staging] but the job-level if only runs for PRs targeting dev;
update the on: pull_request -> branches setting to only include dev (replace
[main, dev, staging] with [dev]) so the workflow won't start for non-dev
promotion PRs; modify the branches key under the on: pull_request block in
.github/workflows/changeset.yml to implement this change.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: d3f6bb78-ab07-41d9-b9f3-06cbfb61c7ec

📥 Commits

Reviewing files that changed from the base of the PR and between f21321a and 60e1450.

📒 Files selected for processing (1)
  • .github/workflows/changeset.yml

@himerus himerus merged commit 215fa0a into dev Mar 18, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant