Skip to content

Fix two issues with ast.to_lua_source()#45

Merged
boolangery merged 2 commits into
boolangery:masterfrom
quarantin:master
Sep 11, 2023
Merged

Fix two issues with ast.to_lua_source()#45
boolangery merged 2 commits into
boolangery:masterfrom
quarantin:master

Conversation

@quarantin
Copy link
Copy Markdown
Contributor

@quarantin quarantin commented Jun 3, 2023

This pull request is fixing two issues I've been encountering while using ast.to_lua_source() and for which you have issues opened:

  1. When parsing a return statement that doesn't return a value, the resulting code will be: return False instead of return to_lua_source issue when returning empty value #44
  2. When parsing a local assignment without a value, the resulting code will be: local some_var = instead of local some_var AST deserialization (to_lua_source) issue with assign's that have no values #37

I'm not sure if my patch is the good way to do it, but at least I tested it and it's working as expected.
Please let me know if I should change anything to get my pull-request accepted.

@quarantin quarantin changed the title Small fixes for ast.to_lua_source() Fix two issues with ast.to_lua_source() Jun 3, 2023
@boolangery boolangery merged commit 4a93322 into boolangery:master Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants