CMake: Show used CMake version in super-builds #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's not touch the unrelated prefix logic. Just check the condition again. |
In super-builds show the CMake version which is especially useful on CI to verify the used CMake and/or compare different jobs on failure. Limited to the super build to not be too verbose when Boost is used via add_subdirectory or similar.
Flamefire
force-pushed
the
cmake-version
branch
from
630e65f to
264a16a
Compare
To me it's easier to see all logic happening for super-builds in one block, but sure, easy enough |
|
Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In super-builds show the CMake version which is especially useful on CI to verify the used CMake and/or compare different jobs on failure.
Limited to the super build to not be too verbose when Boost is used via add_subdirectory or similar.
I kept the original call in the latter situation using VERBOSE