Provide wait_list::reserve() method #574
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should help to get rid on unnecessary heap allocations. The wait lists are usually small, which means that just pushing back elements without prior call to reserve has very high chance of hitting capacity limit every time wait_list::insert is called.
|
POCL builds on Travis-CI failed because of a bug in POCL (introduced by pocl/pocl@e796cd1). I'm pretty sure it was fixed by pocl/pocl@c3e93fb. Disadvantage of using master branch. There's no need to retry Travis-CI builds. |
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help to get rid of unnecessary heap allocations.
The wait lists are usually small, which means that just pushing back
elements without prior call to reserve has very high chance of hitting
capacity limit every time wait_list::insert is called.