Skip to content

chore: Fix typo in type alias #1337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2024
Merged

chore: Fix typo in type alias #1337

merged 1 commit into from
Nov 5, 2024

Conversation

@vissarion
Copy link
Member

@vissarion vissarion commented Nov 5, 2024

No description provided.

barendgehrels
barendgehrels approved these changes Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@barendgehrels barendgehrels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, sorry. Thanks for the fix!
How come it was not triggering a build failure...

@vissarion
Copy link
Member Author

vissarion commented Nov 5, 2024

Oops, sorry. Thanks for the fix! How come it was not triggering a build failure...

In PRs the CI runs only minimal tests https://github.com/boostorg/geometry/blob/develop/.github/workflows/minimal.yml and the whole suite is executed after merging into develop branch.

@vissarion vissarion merged commit 2acb7eb into boostorg:develop Nov 5, 2024
23 checks passed
@vissarion vissarion deleted the fix/typo branch November 5, 2024 13:40
@barendgehrels
Copy link
Collaborator

barendgehrels commented Nov 5, 2024 •
edited
Loading

Oops, sorry. Thanks for the fix! How come it was not triggering a build failure...

In PRs the CI runs only minimal tests https://github.com/boostorg/geometry/blob/develop/.github/workflows/minimal.yml and the whole suite is executed after merging into develop branch.

But I compile all also locally with CMake... however, I see it now. Exactly this one was excluded...

if (NOT APPLE)
    # The results of these tests vary considerably on Apple/Darwin/arm64 using clang
    foreach(item IN ITEMS
        envelope_on_spheroid...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@barendgehrels barendgehrels barendgehrels approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vissarion @barendgehrels