[strategies][cart_intersect] Compare ratios denominators consistently. #267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compare both ratios' potential denominators, corresponding to both segments. Furthermore, take into account the machine epsilon.
Collaborator
|
I'm OK with this, thanks |
awulkiew
added a commit
that referenced
this pull request
Mar 22, 2015
[strategies][cart_intersect] Compare ratios denominators consistently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compare both ratios' potential denominators, corresponding to both
segments. Furthermore, take into account the machine epsilon.
Without this change an assertion
ratio.denominator() != 0can fail in intersection_points.hpp line 62, in segments_intersection_points policy. And indeed it fails e.g. in get_turns_linear_linear.cpp unit test if compiled in MinGW with -O2.Furthermore, if compiled with -O2, the tests which "normally" was passing fails. Some of those cases are fixed if the denominators are compared WRT machine epsilon.
However not all of them. AFAIU the reason is different and related to the way how the determinant is calculated. See this PR: #259 and this ticket: https://svn.boost.org/trac/boost/ticket/8379.