- 
                Notifications
    
You must be signed in to change notification settings  - Fork 43
 
Makes all objects in connection have a stable address #285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makes all objects in connection have a stable address #285
Conversation
| 
           This is intended to alleviate one of the problems you had in #283, and make reasoning about lifetimes trivial. Before I add some tests to verify that moving  I could also make   | 
    
| 
           AFAICS this is only needed if we want to support a connection being moved while   | 
    
| 
           It's aimed to solve things like this: #283 (comment) This would cause a segfault after moving the connection, whether you perform the move before, during or after async_run executes. IMO not having to reason about lifetimes at all makes things much easier.  | 
    
| 
           Hi Ruben, I am going to address those comments in the way you suggested. Just don't have much time now. I agree what you propose here is good (and common) practice and does not have any bad side effects. I support further development here, thanks.  | 
    
| 
           Great. I will do some further fixes here and post it for review again. I'm going to be out of office during the weekend too, so don't worry.  | 
    
| 
           This is now ready @mzimbres. I've made all composed operations use   | 
    
Moves read_buffer memory reservation to the connection's constructor
Makes read_buffer memory reservation size be a power of 2