Reduces the time elapsed by test_conn_health_check and adds test_conn_monitor #316
+168
−98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is an intent to make test_conn_health_check more workable. It now uses a simple BLPOP that will wait forever and cause the connection to be killed. Runtime is down from 30s to 1s. Since this test was covering MONITOR, I've added a test that just does this. This test runs almost instantly. |
mzimbres
reviewed
Sep 27, 2025
|
|
||
| namespace { | ||
|
|
||
| struct push_callback { |
There was a problem hiding this comment.
Glad this is being removed, it is a mess.
mzimbres
reviewed
Sep 27, 2025
|
|
||
| // Verifies that using the MONITOR command works properly. | ||
| // Opens a connection, issues a MONITOR, issues some commands to | ||
| // generate some traffic, and waits for several MONITOR messages to arrive. |
There was a problem hiding this comment.
// Opens a connection, issues a MONITOR, issues some commands to
// generate some traffic, and waits for several MONITOR messages to arrive.
I thought it was not allowed to issue commands on the same connection one MONITOR mode is entered. Perhaps this was only a restriction in RESP2 since it does not support server pushes.
mzimbres
approved these changes
Sep 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splits test_conn_health_check into a test to verify that the health checker works and another to verify that MONITOR is handled correctly.
Tests no longer wait or use CLIENT PAUSE