Skip to content

Commit 4fe2438

Browse files
committed
fix: decode_view::ends_with with empty string
1 parent d06df88 commit 4fe2438

File tree

2 files changed

+8
-0
lines changed

2 files changed

+8
-0
lines changed

src/decode_view.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,8 @@ bool
105105
decode_view::
106106
ends_with( core::string_view s ) const noexcept
107107
{
108+
if (s.empty())
109+
return true;
108110
if (s.size() > size())
109111
return false;
110112
auto it0 = end();

test/unit/decode_view.cpp

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -230,6 +230,12 @@ struct decode_view_test
230230
BOOST_TEST_NOT(s.ends_with("url test"));
231231
}
232232

233+
// ends_with() empty string regression
234+
{
235+
BOOST_TEST(decode_view("anything").ends_with(""));
236+
BOOST_TEST(decode_view("").ends_with(""));
237+
}
238+
233239
// find()
234240
{
235241
decode_view s(str);

0 commit comments

Comments
 (0)