fix: url_base loop condition order

Author: alandefreitas

include/boost/url/impl/url_base.hpp

@@ -245,8 +245,8 @@ remove_scheme()
         auto begin = s_ + impl_.offset(id_path);
         auto it = begin;
         auto end = begin + pn;
-        while (*it != '/' &&
-               it != end)
+        while (it != end &&
+               *it != '/')
             ++it;
         // we don't need op here because this is
         // an internal operation
@@ -2089,8 +2089,8 @@ normalize_path()
         auto end = begin + pn;
         while (core::string_view(it, 2) == "./")
             it += 2;
-        while (*it != '/' &&
-               it != end)
+        while (it != end &&
+               *it != '/')
             ++it;
         // we don't need op here because this is
         // an internal operation
@@ -2614,8 +2614,10 @@ first_segment() const noexcept
             p0, end - p0);
     auto p = p0;
     while(*p != '/')
+    {
+        BOOST_ASSERT(p < end);
         ++p;
-    BOOST_ASSERT(p < end);
+    }
     return core::string_view(p0, p - p0);
 }
 

test/unit/url_base.cpp

@@ -1860,6 +1860,23 @@ struct url_base_test
         assert( url( "http://www.example.com#%61bc" ).normalize_fragment().buffer() == "http://www.example.com#abc" );
     }
 
+    void
+    testSetEncodedPathBoundary()
+    {
+        // exercise paths that end exactly at
+        // iterator boundary (OOB read regression)
+        {
+            url u;
+            u.set_encoded_path("x");
+            BOOST_TEST_EQ(u.encoded_path(), "x");
+        }
+        {
+            url u;
+            u.set_encoded_path("");
+            BOOST_TEST(u.encoded_path().empty());
+        }
+    }
+
     void
     run()
     {
@@ -1871,6 +1888,7 @@ struct url_base_test
         testSetHost();
         testSetPort();
         testQuery();
+        testSetEncodedPathBoundary();
         testJavadocs();
     }
 };