fix: recycled_ptr::get() nullptr when empty

alandefreitas · alandefreitas · commit d4ae92d51f0a · 2026-03-02T19:44:17.000-05:00
diff --git a/include/boost/url/grammar/recycled.hpp b/include/boost/url/grammar/recycled.hpp
@@ -451,7 +451,7 @@ class recycled_ptr
     */
     T* get() const noexcept
     {
-        return &p_->t;
+        return p_ ? &p_->t : nullptr;
     }
 
     /** Return the referenced object
diff --git a/test/unit/grammar/recycled.cpp b/test/unit/grammar/recycled.cpp
@@ -48,6 +48,14 @@ struct recycled_test
             BOOST_TEST(sp2->capacity() >= 1000);
         }
 
+        // get() returns nullptr after release
+        {
+            recycled_ptr<std::string> sp;
+            sp->reserve(100);
+            sp.release();
+            BOOST_TEST(sp.get() == nullptr);
+        }
+
         // coverage
         {
             implementation_defined::recycled_add_impl(1);

Original file line number	Diff line number	Diff line change
`@@ -451,7 +451,7 @@ class recycled_ptr`
`451`	`451`	`*/`
`452`	`452`	`T* get() const noexcept`
`453`	`453`	`{`
`454`		`- return &p_->t;`
	`454`	`+ return p_ ? &p_->t : nullptr;`
`455`	`455`	`}`
`456`	`456`
`457`	`457`	`/** Return the referenced object`
Original file line number	Diff line number	Diff line change
`@@ -48,6 +48,14 @@ struct recycled_test`
`48`	`48`	`BOOST_TEST(sp2->capacity() >= 1000);`
`49`	`49`	`}`
`50`	`50`
	`51`	`+ // get() returns nullptr after release`
	`52`	`+ {`
	`53`	`+ recycled_ptr<std::string> sp;`
	`54`	`+ sp->reserve(100);`
	`55`	`+ sp.release();`
	`56`	`+ BOOST_TEST(sp.get() == nullptr);`
	`57`	`+ }`
	`58`	`+`
`51`	`59`	`// coverage`
`52`	`60`	`{`
`53`	`61`	`implementation_defined::recycled_add_impl(1);`