This repository was archived by the owner on Feb 27, 2018. It is now read-only.
Merged
Conversation
Contributor
Author
|
I might disable using the serial port by default and use a cmdline option for 0.12 and see ifi cna get further on the w/e |
Contributor
There was a problem hiding this comment.
Why not just IP = vals... ?
Contributor
|
after comments are addressed, LGTM |
This will provide us with a backchannel to get the host only IP on VM platforms that don't have nat-style port forwarding, and hopefully will make it possible to get a more reliable VM status
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
work in progress - I'm finding failure modes that I hope to debug first