Skip to content
This repository was archived by the owner on Feb 27, 2018. It is now read-only.

VBox 3.4.12 has changed the install path ENV#143

Merged
SvenDowideit merged 1 commit into
boot2docker:masterfrom
SvenDowideit:vbox-3.4.12-needs
Jun 6, 2014
Merged

VBox 3.4.12 has changed the install path ENV#143
SvenDowideit merged 1 commit into
boot2docker:masterfrom
SvenDowideit:vbox-3.4.12-needs

Conversation

@SvenDowideit
Copy link
Copy Markdown
Contributor

from VBOX_INSTALL_PATH to VBOX_MSI_INSTALL_PATH

@gmlewis
Copy link
Copy Markdown
Contributor

gmlewis commented Jun 6, 2014

LGTM

@SvenDowideit
Copy link
Copy Markdown
Contributor Author

Comment thread config.go Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not else if ... instead of this nested stuff?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

else if is just as nested as what i have - but like, whateva :)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No wai, it drops a full level of indentation and a pair of curly braces!

from VBOX_INSTALL_PATH to VBOX_MSI_INSTALL_PATH
SvenDowideit pushed a commit that referenced this pull request Jun 6, 2014
VBox 3.4.12 has changed the install path ENV
@SvenDowideit SvenDowideit merged commit 29a1310 into boot2docker:master Jun 6, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants