This repository was archived by the owner on Feb 27, 2018. It is now read-only.
Now that getting the IP is much more reliable, using the forwarded port ...#189
Merged
SvenDowideit merged 1 commit intoJul 10, 2014
Conversation
Contributor
Author
|
@tianon @gmlewis @crosbymichael @steeve I'm putting this into the 1.1.1 I'm about to release |
Contributor
|
Much constant, such magic number, many duplication, so undry. |
Contributor
There was a problem hiding this comment.
How about putting this near the beginning of this file and use it in the 3 places this file uses 2375?
const dockerPort = 2375
Contributor
|
otherwise, LGTM |
Contributor
Author
|
only because it'd be 2 more lines of change :) one 🕛 |
…rt here is much more dangerous
Contributor
Author
|
@tianon ! - though its not a shared constant - its only local to that file, which made me cry. |
SvenDowideit
pushed a commit
that referenced
this pull request
Jul 10, 2014
Now that getting the IP is much more reliable, using the forwarded port ...
Contributor
Author
|
making assumptions - and kicking off an automated build |
Contributor
|
Much better, and LGTM now. |
SvenDowideit
added a commit
to SvenDowideit/boot2docker-cli
that referenced
this pull request
Nov 10, 2014
Documentation for the workarounds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...here is much more dangerous
closes #118