Skip to content
This repository was archived by the owner on Feb 27, 2018. It is now read-only.

Driver extraction part2#207

Merged
SvenDowideit merged 3 commits intoboot2docker:masterfrom
SvenDowideit:driver-extraction-part2
Aug 6, 2014
Merged

Driver extraction part2#207
SvenDowideit merged 3 commits intoboot2docker:masterfrom
SvenDowideit:driver-extraction-part2

Conversation

@SvenDowideit
Copy link
Contributor

this will bring back @zeeyang's work from #184

@SvenDowideit
Copy link
Contributor Author

@tianon @zeeyang @crosbymichael @gmlewis @steeve

the sooner we merge this the better (the first commit obviously has already been reviewed)

cmds.go Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/iso/ISO/
s/its/it's/

@gmlewis
Copy link
Contributor

gmlewis commented Jul 31, 2014

A few nits, otherwise LGTM

@SvenDowideit
Copy link
Contributor Author

@zeeyang one problem I have with this refactor, is that its removed all traces of user feedback once inside the driver.

we need to work out how to bring that back - preferably in a way that the 'verbose' output can be stored, and printed on error.

compare the output of boot2docker -v stop

bash-3.2$ ./boot2docker-v1.2.0-pre-darwin-amd64 status
running
bash-3.2$ ./boot2docker-v1.2.0-pre-darwin-amd64 -v stop
bash-3.2$ ./boot2docker-v1.1.0-
boot2docker-v1.1.0-darwin-amd64       boot2docker-v1.1.0-linux-amd64        boot2docker-v1.1.0-windows-amd64.exe
bash-3.2$ ./boot2docker-v1.1.0-darwin-amd64 start
2014/07/31 16:41:48 Waiting for VM to be started...
.......
2014/07/31 16:42:10 Started.
2014/07/31 16:42:10 To connect the Docker client to the Docker daemon, please set:
2014/07/31 16:42:10     export DOCKER_HOST=tcp://192.168.59.103:2375
bash-3.2$ ./boot2docker-v1.1.0-darwin-amd64 -v stop
2014/07/31 16:42:17 executing: VBoxManage showvminfo boot2docker-vm --machinereadable
2014/07/31 16:42:17 executing: VBoxManage controlvm boot2docker-vm acpipowerbutton
2014/07/31 16:42:18 executing: VBoxManage showvminfo boot2docker-vm --machinereadable
2014/07/31 16:42:18 executing: VBoxManage controlvm boot2docker-vm acpipowerbutton
2014/07/31 16:42:19 executing: VBoxManage showvminfo boot2docker-vm --machinereadable
2014/07/31 16:42:19 executing: VBoxManage controlvm boot2docker-vm acpipowerbutton
2014/07/31 16:42:20 executing: VBoxManage showvminfo boot2docker-vm --machinereadable
2014/07/31 16:42:20 executing: VBoxManage controlvm boot2docker-vm acpipowerbutton
2014/07/31 16:42:21 executing: VBoxManage showvminfo boot2docker-vm --machinereadable
2014/07/31 16:42:21 executing: VBoxManage controlvm boot2docker-vm acpipowerbutton
2014/07/31 16:42:22 executing: VBoxManage showvminfo boot2docker-vm --machinereadable
bash-3.2$ 

@SvenDowideit
Copy link
Contributor Author

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much love, this needed a comment so we didn't fall down into that trap again. :)

@tianon
Copy link
Contributor

tianon commented Aug 5, 2014

Seems sane enough - we can obviously iterate as we go from here :)

@tianon
Copy link
Contributor

tianon commented Aug 5, 2014

I'm assuming you'll rebase/shuffle #187 once this is nailed down and merged?

@SvenDowideit
Copy link
Contributor Author

yup - or re-write - that was the more naive impl i could muster, and I really would like to be able to talk to it from outside too (qemu networking, so fun)

SvenDowideit pushed a commit that referenced this pull request Aug 6, 2014
@SvenDowideit SvenDowideit merged commit cb1ea83 into boot2docker:master Aug 6, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should check for the return value of Register and exit on error.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants