Driver extraction part2#207
Conversation
|
@tianon @zeeyang @crosbymichael @gmlewis @steeve the sooner we merge this the better (the first commit obviously has already been reviewed) |
cmds.go
Outdated
|
A few nits, otherwise LGTM |
|
@zeeyang one problem I have with this refactor, is that its removed all traces of user feedback once inside the driver. we need to work out how to bring that back - preferably in a way that the 'verbose' output can be stored, and printed on error. compare the output of |
There was a problem hiding this comment.
Much love, this needed a comment so we didn't fall down into that trap again. :)
|
Seems sane enough - we can obviously iterate as we go from here :) |
|
I'm assuming you'll rebase/shuffle #187 once this is nailed down and merged? |
|
yup - or re-write - that was the more naive impl i could muster, and I really would like to be able to talk to it from outside too (qemu networking, so fun) |
There was a problem hiding this comment.
We should check for the return value of Register and exit on error.
this will bring back @zeeyang's work from #184