This repository was archived by the owner on Feb 27, 2018. It is now read-only.
Revert "Add Fusion driver and vmx template"#333
Merged
Conversation
Contributor
|
👍 We don't want to be adding complex features that need maintaining when we are in the process of replacing boot2docker-cli with Machine. |
Contributor
Author
|
I think it's also prudent to point out docker-archive-public/docker.machine#6 here, which is the currently open VMware PR for Docker Machine. |
Contributor
|
ok, LGTM |
tianon
added a commit
that referenced
this pull request
Jan 14, 2015
Revert "Add Fusion driver and vmx template"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #265
I'm not comfortable releasing with this merged, and I don't want code in master that we're not comfortable releasing, especially since we're in bugfix mode on boot2docker-cli. If someone wants to take over these changes in a new PR (ie, #328 or #331), that would be more appropriate, but I'm still wary.
It also seems wasteful to be splintering development effort between boot2docker-cli and Docker Machine, when Docker Machine is definitely going to be the path forward, so I don't feel very good about integrating such large features here either, when they definitely won't get the love and attention they deserve (but would if they were in Docker Machine, which this particular feature is).
Perhaps @bfirsh has more thoughts on this, but I'm going to submit a follow-up PR shortly to update the README to make this project's future more clear.