This repository was archived by the owner on Feb 27, 2018. It is now read-only.
Make |boot2docker up| mention eval "$(boot2docker shellinit)"#370
Merged
tianon merged 1 commit intoboot2docker:masterfrom Jun 26, 2015
edmorley:mention-shellinit-on-up
Merged
Make |boot2docker up| mention eval "$(boot2docker shellinit)"#370tianon merged 1 commit intoboot2docker:masterfrom edmorley:mention-shellinit-on-up
eval "$(boot2docker shellinit)"#370tianon merged 1 commit intoboot2docker:masterfrom
edmorley:mention-shellinit-on-up
Conversation
Whilst the boot2docker docs have been updated with the improved shellinit pattern that uses eval (see boot2docker/boot2docker#786), many unofficial boot2docker articles/guides still use the old form. To increase awareness of the corrected version, it's now output at the end of |boot2docker up|. Fixes #369.
Contributor
Author
|
Is there anything else I need to do for this to be merged? :-) |
Contributor
|
LGTM. |
Contributor
|
LGTM |
tianon
added a commit
that referenced
this pull request
Jun 26, 2015
Make |boot2docker up| mention `eval "$(boot2docker shellinit)"`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whilst the boot2docker docs have been updated with the improved shellinit pattern that uses eval (see boot2docker/boot2docker#786), many unofficial boot2docker articles/guides still use the old form.
To increase awareness of the corrected version, it's now output at the end of |boot2docker up|.
Fixes #369.