Minor cleanup, prettier output#1
Merged
Merged
Conversation
nebkor
commented
Mar 21, 2018
nebkor
left a comment
nebkor
left a comment
Contributor
Author
There was a problem hiding this comment.
ah, darnit, this really should have been part of the next commit for quieting clippy warnings.
Owner
|
thanks - Most definitely worth merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a really great little tool! I noticed some compiler warnings when I built it locally, and I thought the box construction characters could be slightly fancier, so there you go. I split the changes into several commits, and the only one that changes behavior is the last one, 1c80cbf, "Make printing slightly prettier." I'm not sure this PR is worth merging, just FYI. Also, I might change it a little more aggressively, like factor it into a lib crate and a bin crate, and possibly try to speed it up.