Skip to content

Compile and "function" under wasi#133

Closed
jcaesar wants to merge 2 commits into
bootandy:masterfrom
jcaesar:wasi
Closed

Compile and "function" under wasi#133
jcaesar wants to merge 2 commits into
bootandy:masterfrom
jcaesar:wasi

Conversation

@jcaesar
Copy link
Copy Markdown

@jcaesar jcaesar commented Jan 18, 2021

Sorry for the noise: This is a PR I expect you not to merge, but to close.

Reasons being

  • It requires some unpublished / unmerged changes to lscolors and terminal-size
  • Getting util to function in an environment without threads, without slowing down all other "proper" platforms, requires somewhat nasty code changes
  • Some wasi implementations expose incorrect / 0 values for dev/inode, so the results may be incorrect
  • wasi doesn't expose a block size, so the results are definitely incorrect / always in apparent-size mode

The reasons I'm still making this PR are that

  1. To show that somebody was "bored" enough to do it. ;)
  2. To avoid anybody else getting the same idea, checking the issues for wasm/wasi, and not finding this
  3. In the off case that you're super-enthusiastic about wasm/wasi, you can tell me and I will reopen this once the dependency changes have been merged and published.

@jcaesar jcaesar force-pushed the wasi branch 5 times, most recently from 7cf6a8a to fa7a72a Compare January 20, 2021 04:13
@bootandy
Copy link
Copy Markdown
Owner

thanks for looking at this @jcaesar I'll do my best to remember should wasi come up again.

@bootandy bootandy closed this Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants