Skip to content

add aarch64 gnu and musl cross targets#215

Merged
bootandy merged 1 commit into
bootandy:masterfrom
adamcstephens:add-aarch64
Feb 27, 2022
Merged

add aarch64 gnu and musl cross targets#215
bootandy merged 1 commit into
bootandy:masterfrom
adamcstephens:add-aarch64

Conversation

@adamcstephens

Copy link
Copy Markdown
Contributor

I get why you don't like working on this. :)

This will build tarballs for Linux aarch64 gnu and musl targets. I couldn't get the musl debs building because I wasn't sure how to provide the correct strip binary. Either way this still seems an improvement towards #200

Here's the error if you know a quick fix.

/home/runner/.cargo/bin/cargo deb --no-build --target=aarch64-unknown-linux-musl
strip: Unable to recognise the format of the input file `/home/runner/work/dust/dust/target/aarch64-unknown-linux-musl/release/dust'
cargo-deb: unable to strip binary '/home/runner/work/dust/dust/target/aarch64-unknown-linux-musl/release/dust': strip: exit status: 1.
hint: Target-specific strip commands are configured in [target.aarch64-unknown-linux-musl] strip = { path = "strip" } in .cargo/config

command: install
args: cargo-deb
if: ${{ contains(matrix.job.target, 'musl') }}
if: matrix.job.target == 'i686-unknown-linux-musl' || matrix.job.target == 'x86_64-unknown-linux-musl'

@adamcstephens adamcstephens Feb 27, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed templating per docs

When you use expressions in an if conditional, you may omit the expression syntax (${{ }}) because GitHub automatically evaluates the if conditional as an expression.

@bootandy

Copy link
Copy Markdown
Owner

Thank you, I appreciate you looking at this,

I built an alpha release with the new builds here:
https://github.com/bootandy/dust/releases

@bootandy bootandy merged commit 48bf656 into bootandy:master Feb 27, 2022
@adamcstephens adamcstephens deleted the add-aarch64 branch February 27, 2022 14:35
@adamcstephens

Copy link
Copy Markdown
Contributor Author

Just wanted to report that this has been working flawlessly for me across aarch64 and musl systems.

@bootandy

Copy link
Copy Markdown
Owner

thank you @adamcstephens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants