Skip to content

Fix error on thread creation2#258

Closed
bootandy wants to merge 2 commits into
masterfrom
fix_error_on_thread_creation2
Closed

Fix error on thread creation2#258
bootandy wants to merge 2 commits into
masterfrom
fix_error_on_thread_creation2

Conversation

@bootandy
Copy link
Copy Markdown
Owner

Should Fix: #256

User reported this unwrap could fail, so log an error instead of using a
naked unwrap.
@bootandy bootandy marked this pull request as ready for review August 25, 2022 09:41
@AminurAlam
Copy link
Copy Markdown
Contributor

AminurAlam commented Aug 26, 2022

doesn't seem to fix the issue

$ git clone --depth 1 --branch 'fix_error_on_thread_creation2' 'https://github.com/bootandy/dust/'
$ cd dust
$ cargo run

20220826_194714
first one is from repository
second one is compiled from source
third one is compiled from this pr
using rustc 1.62.1

@bootandy
Copy link
Copy Markdown
Owner Author

Ok, thanks for the information let me try again.

@bootandy bootandy closed this Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

panicked at 'called Result::unwrap()

2 participants