#321: display the size of a file or directory in "kilobytes"#322
Closed
TYzzt wants to merge 3 commits into
Closed
Conversation
TYzzt
changed the title
Contributor
Author
|
hi, @bootandy, could you please help me review the code |
Owner
|
your code looks good. |
Owner
|
I think the code you have written is sensible. But I'm just not sure that we need to cover this usecase. |
Contributor
Author
|
thank you~ The kilobyte formatting is very useful in scenarios where higher precision is required. This is also the requirement that my work encounters. |
|
I would also like this, as well as bytes (aka the non human-readable version of |
Owner
|
Commits from this PR moved to the above PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added -k parameter to display the size of a file or directory in "kilobytes"