Fix filename completions

[bootandy]

I previously accidentally reverted a commit that @wickles made to fix the completion.

#359

[wickles]

Maybe I'm wrong but I think there needs to be an adjustment to the completion generation in build.rs and src/cli.rs, or else clap will just revert this again with the next build.

[wickles]

This does not work. Remove the new line and replace the existing line with

'*::params:_files' \

[bootandy]

Happy to make this change.

When I test tab completion it seems to work for me.

How would you recommend that I test this? & How do you know this is the right thing to do ?

Thanks

[wickles]

Just edit the existing file in your fpath and then start a new zsh session. When I try with both *:... lines added:

❯ dust <tab>
_arguments:comparguments:327: doubled rest argument definition: *:inputs:_files
_arguments:comparguments:327: doubled rest argument definition: *:inputs:_files
❯ dust 

compared with the one line as in my suggestion:

❯ dust <tab>
-- params --
Desktop/  Documents/ ...

[bootandy]

Maybe I'm wrong but I think there needs to be an adjustment to the completion generation in build.rs and src/cli.rs, or else clap will just revert this again with the next build.

You are right, going to rethink this.

[bootandy]

There's a lot of auto complete issues raised in clap-complete. https://github.com/clap-rs/clap/issues?page=2&q=is%3Aissue+is%3Aopen+completion

A (rather hacky) solution could be to add a comment saying 'do not commit this change' if clap rebuilds it. Although, ideally we want to fix the root problem which is either in clap-complete or my use of clap.