Clippy#39
Closed
lespea wants to merge 2 commits into
Closed
Conversation
Owner
|
Hi, Firstly thanks for the pull request. I like most of your changes but there are 2 things I'd like to change: The collapsed if-then-else branches - I would like to leave these as they were as it is easier to understand them (we could put them in to two functions if you'd prefer). Using the 'either' crate. To me it has hidden something in the way that 'get_children_from_node' works. I'd rather be more explicit even if I have to do a But I like the other changes: removing box, changing iter to intoIter & getting rid of a few Somes. So if you could undo the if/else squashing and the either crate I'd happily accept this merge. thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bunch of clippy warnings which includes:
Let me know if some of these changes you don't want (specifically the collapsed if-then-else branches you may prefer the original... I just went for cleaning everything for a first pass.