use LS_COLORS for largest subdirectories#79
Merged
Conversation
Owner
|
Looks good, I like your changes. We have a conflict as I moved the line handling colorized output just before this was opened, but this should be easy to fix when you rebase. I will happily merge when the conflict is resolved. |
Contributor
Author
|
Thank you. Rebased without conflicts, would you like me to squash everything in to one commit? |
Owner
|
Thanks, No. I prefer several small commits. Thanks for introducing me to ls_colors library too. It is giving me ideas. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses directory colour defined in $LS_COLORS to paint the largest subdirectories instead of red.
Fixed a compiler warning, updated the readme, changed args descriptions and made some consistency changes to clap args.