integration-tests: Add macro to reduce test registration boilerplate #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The goal is to reduce boilerplate. Assisted-by: Claude Code (Sonnet 4.5) Signed-off-by: Colin Walters <walters@verbum.org>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces integration_test! and parameterized_integration_test! macros to reduce boilerplate in test registration, which is a great improvement for maintainability. The macros are well-implemented and correctly applied to numerous integration tests, cleaning up a lot of repetitive code and standardizing test names. As a minor follow-up, the new parameterized_integration_test! macro could also be applied to test_run_ephemeral_ssh_cross_distro_compatibility in crates/integration-tests/src/tests/run_ephemeral_ssh.rs to complete the refactoring. Overall, this is a solid contribution that improves the test suite's structure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to reduce boilerplate.
Assisted-by: Claude Code (Sonnet 4.5)