libvirt run: Add --ssh-wait flag for test integration #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a --ssh-wait flag to libvirt run for testing purposes, which waits for SSH to be ready without starting an interactive shell. The implementation refactors the SSH waiting logic into a generic wait_for_readiness utility, which is a great improvement for code reuse.
My review focuses on improving the CLI experience, maintainability, and ensuring the new functionality is properly tested. I've identified a critical missing test implementation for the new flag and suggested several medium-severity improvements, including making conflicting CLI flags explicit, improving logging behavior, and increasing code consistency.
Add a new `--ssh-wait` flag to `bcvk libvirt run` that waits for SSH to become available without entering an interactive shell. This is designed for use in test suites that need to verify a VM is fully booted and SSH-ready before proceeding with additional operations. The `--ssh` flag behavior now also starts using this code, as does some of the integration tests. Assisted-by: Claude Code (Sonnet 4.5) Signed-off-by: Colin Walters <walters@verbum.org>
cgwalters
force-pushed
the
libvirt-run-ssh-wait
branch
from
8608d6d to
21ff95b
Compare
jeckersb
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new
--ssh-waitflag tobcvk libvirt runthat waits for SSH to become available without entering an interactive shell. This is designed for use in test suites that need to verify a VM is fully booted and SSH-ready before proceeding with additional operations.The
--sshflag behavior now also starts using this code, as does some of the integration tests.Assisted-by: Claude Code (Sonnet 4.5)