libvirt: Fix --transient --replace removing non-existent domains #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When replacing a transient VM, the old VM disappears after `virsh destroy` since transient domains are not persistent. Previously, the remove logic would then fail trying to `virsh undefine` a domain that no longer exists. Detect transient VMs explicitly to handle their removal. Assisted-by: OpenCode (claude-sonnet-4-20250514) Signed-off-by: Colin Walters <walters@verbum.org>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request fixes an issue where replacing a transient VM would fail because the old VM, being transient, disappears after being destroyed, causing the subsequent undefine operation to fail. The fix correctly detects if a VM is transient and skips the undefine step in that case. A new function is_domain_persistent is added for this detection, and the removal logic is updated accordingly. A comprehensive integration test is also added to validate the fix. The changes are logical and well-tested. I have one critical suggestion to improve the error handling to avoid masking potential issues.
jeckersb
approved these changes
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When replacing a transient VM, the old VM disappears after
virsh destroysince transient domains are not persistent. Previously, the remove logic would then fail trying tovirsh undefinea domain that no longer exists.Detect transient VMs explicitly to handle their removal.
Assisted-by: OpenCode (claude-sonnet-4-20250514)