packit: Add CentOS Stream dist-git branches#226
Conversation
There was a problem hiding this comment.
Code Review
This pull request correctly adds CentOS Stream 9 and 10 branches to the packit configuration for downstream proposals and Koji builds. My review includes suggestions to improve the maintainability and consistency of the configuration by reordering the new branches and using YAML anchors to avoid duplication.
Signed-off-by: gursewak1997 <gursmangat@gmail.com>
bad6de6 to
1d25012
Compare
| trigger: release | ||
| dist_git_branches: | ||
| - fedora-all | ||
| - c9s |
There was a problem hiding this comment.
If we put bcvk.spec file into dist-git. Fedora and CS might need different spec file. According to Failure has been fixed by PR bootc-dev/bootc#1986, the package name should be different for different spec file.
There was a problem hiding this comment.
Why would the package name be different? I don't understand the problem
| trigger: release | ||
| dist_git_branches: | ||
| - fedora-all | ||
| - c9s |
There was a problem hiding this comment.
Why would the package name be different? I don't understand the problem
This should've been included in last PR but let's configure packit to propose updates to CentOS Stream 9 and 10 dist-git repositories and trigger Koji builds on commits.